Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PWA): add Install prompts #823

Merged
merged 5 commits into from Aug 28, 2023

Conversation

ruchamahabal
Copy link
Member

@ruchamahabal ruchamahabal commented Aug 28, 2023

https://web.dev/customize-install/

Any browser (updated in 4a04b45) vs. iOS (updated in 12cd4f5)

image image

iOS

Safari doesn't support window.addEventListener("beforeinstallprompt"). So the installation cannot be triggered. Show a popover explaining how to install the app on iOS

Firefox requires an extension 馃様

TODO: Add docs for compatibility

image

Ref: https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Guides/Installing
no-docs

@ruchamahabal ruchamahabal changed the title feat: add Install prompt for PWA feat(PWA): add Install prompt Aug 28, 2023
@ruchamahabal ruchamahabal changed the title feat(PWA): add Install prompt feat(PWA): add Install prompts Aug 28, 2023
@ruchamahabal ruchamahabal merged commit 38046b1 into frappe:mobile Aug 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant